update to api-common 1.8.1 #5015
Conversation
googlebot
added
the
cla: yes
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| <http-client-bom.version>1.29.0</http-client-bom.version> | ||
| <oauth-client.version>1.28.0</oauth-client.version> | ||
| <protobuf.version>3.7.0</protobuf.version> | ||
| <protobuf.version>3.7.1</protobuf.version> |
There was a problem hiding this comment.
Interesting.. grpc is still on 3.6.1 as of their 1.19.0 release. grpc 1.20.0 upgraded protobuf to 3.7.1. I think that we ought to upgrade grpc as well, and probably opencensus to 0.19.2
There was a problem hiding this comment.
Yes, that makes sense. Not sure any of this is going to work though. There's a dependency-convergence error in google-cloud-core. Probably have to push api-common 1.8.1 and try again to fix that.
There was a problem hiding this comment.
1.8.1 is out for api-common-java
There was a problem hiding this comment.
upgraded to 1.8.1; testing now
There was a problem hiding this comment.
[ERROR] Errors:
[ERROR] com.google.cloud.datastore.DatastoreTest.com.google.cloud.datastore.DatastoreTest
[ERROR] Run 1: DatastoreTest.beforeClass:157 » IllegalArgument Invalid version format
[ERROR] Run 2: DatastoreTest.afterClass:179 » Connect Connection refused (Connection refused)
[INFO]
[ERROR] LocalDatastoreHelperTest.testStartStopReset:94 » IllegalArgument Invalid versi...
[INFO]
[ERROR] Tests run: 168, Failures: 0, Errors: 2, Skipped: 0
[INFO]
Codecov Report
@@ Coverage Diff @@
## master #5015 +/- ##
============================================
+ Coverage 50.32% 50.32% +<.01%
+ Complexity 23680 23675 -5
============================================
Files 2238 2238
Lines 226060 226063 +3
Branches 24955 24961 +6
============================================
+ Hits 113769 113771 +2
- Misses 103686 103687 +1
Partials 8605 8605
Continue to review full report at Codecov.
|
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Ping. api-common 1.8.1 does seem to work here.
For convergence or for tests? It looks like CI passed for the unit tests. |
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
It passes as much convergence as google-cloud-java checks, which 1.8.0 didn't do. Also passes unit tests.
|
Oops, I misread your comment as it didn't pass. |
6 participants
@andreamlin