Skip to content

Regenerate Cloud Talent #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 25, 2019
Merged

Regenerate Cloud Talent #5013

sduskis merged 1 commit into from
Apr 25, 2019

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Apr 25, 2019 •
edited
Loading

Replaces #5000.

Repro steps:

  1. Delete google-api-grpc/proto-google-cloud-talent-v4beta1/src and google-api-grpc/grpc-google-cloud-talent-v4beta1/src
  2. Run the synthtool inside the cloud talent directory, as usual.

@andreamlin andreamlin requested a review from a team as a code owner April 25, 2019 00:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #5013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5013   +/-   ##
=========================================
  Coverage     50.32%   50.32%           
  Complexity    23672    23672           
=========================================
  Files          2238     2238           
  Lines        226060   226060           
  Branches      24959    24959           
=========================================
  Hits         113766   113766           
  Misses       103689   103689           
  Partials       8605     8605
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/talent/v4beta1/JobServiceClient.java 42.64% <ø> (ø) 26 <0> (ø) ⬇️
...gle/cloud/talent/v4beta1/CompanyServiceClient.java 59.25% <ø> (ø) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870d214...6f17fb4. Read the comment docs.

@andreamlin andreamlin requested a review from sduskis April 25, 2019 00:47
@andreamlin
Copy link
Contributor Author

andreamlin commented Apr 25, 2019

PTAL
Please merge if LGTM

@sduskis sduskis merged commit e67fd01 into googleapis:master Apr 25, 2019
@andreamlin andreamlin deleted the talent branch April 25, 2019 03:48
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreamlin @sduskis @googlebot