Skip to content

Enhancing Publisher.OutstandingBatch #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
Apr 25, 2019
Merged

Enhancing Publisher.OutstandingBatch #5007

sduskis merged 2 commits into from
Apr 25, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 24, 2019

  • Moving responsibility for creating the SettableFuture into OutstandingBatch
  • Moving responsibility for tracking message size into OutstandingBatch

@sduskis
Enhancing Publisher.OutstandingBatch
bdfae38 
- Moving responsibility for creating the SettableFuture into OutstandingBatch
- Moving responsibility for tracking message size into OutstandingBatch
@sduskis sduskis requested a review from a team as a code owner April 24, 2019 17:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@sduskis sduskis added api: pubsub Issues related to the Pub/Sub API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #5007 into master will decrease coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5007      +/-   ##
============================================
- Coverage     50.32%   50.32%   -0.01%     
- Complexity    23673    23680       +7     
============================================
  Files          2238     2238              
  Lines        226060   226060              
  Branches      24959    24955       -4     
============================================
- Hits         113771   113769       -2     
- Misses       103685   103686       +1     
- Partials       8604     8605       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 82.55% <63.63%> (ø) 27 <0> (ø) ⬇️
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870d214...90e6cd6. Read the comment docs.

@sduskis sduskis merged commit 909b0e8 into googleapis:master Apr 25, 2019
@sduskis sduskis deleted the refactor_pubsub_0424 branch April 25, 2019 15:04
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sduskis @kolea2 @googlebot @yoshi-kokoro