Skip to content

Updating region tags for hello world #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
Apr 24, 2019
Merged

Updating region tags for hello world #5004

sduskis merged 2 commits into from
Apr 24, 2019

Conversation

@billyjacobson
Copy link

@billyjacobson billyjacobson commented Apr 23, 2019

No description provided.

@billyjacobson billyjacobson requested a review from a team as a code owner April 23, 2019 20:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@kolea2
Copy link
Contributor

kolea2 commented Apr 23, 2019

Hi @billyjacobson! The code formatting build failed, please run mvn com.coveo:fmt-maven-plugin:format

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #5004 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5004      +/-   ##
============================================
- Coverage     50.32%   50.31%   -0.01%     
  Complexity    23668    23668              
============================================
  Files          2238     2238              
  Lines        226059   226059              
  Branches      24959    24959              
============================================
- Hits         113754   113751       -3     
- Misses       103704   103707       +3     
  Partials       8601     8601
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/MonitoredResourceUtil.java 50% <0%> (-0.93%) 8% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 40.61% <0%> (-0.88%) 27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95a223...53245fa. Read the comment docs.

igorbernstein2
igorbernstein2 approved these changes Apr 23, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the nit

google-cloud-examples/src/main/java/com/google/cloud/examples/bigtable/HelloWorld.java
import com.google.cloud.bigtable.data.v2.models.RowMutation;
import java.io.IOException;

// [END bigtable_hw_imports_veneer]
Copy link

@igorbernstein2 igorbernstein2 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the empty line above intentional?

@sduskis sduskis merged commit 55f9f52 into master Apr 24, 2019
@chingor13 chingor13 mentioned this pull request Apr 24, 2019
Merged
@sduskis sduskis deleted the cbt-hw-region-tags branch May 1, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@billyjacobson @kolea2 @igorbernstein2 @sduskis @googlebot