Skip to content

Update maven-checkstyle-plugin and puppycrawl checkstyle #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 3 commits into from
May 1, 2019
Merged

Update maven-checkstyle-plugin and puppycrawl checkstyle #5003

kolea2 merged 3 commits into from
May 1, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 23, 2019 •
edited
Loading

  • Update dependencies for: CVE-2019-9658
  • Only run the checkstyle plugin on Java 8+ as the fixed puppycrawl checkstyle artifact only works on Java 8+.

@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Apr 23, 2019
@chingor13 chingor13 requested a review from a team as a code owner April 23, 2019 19:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@chingor13
Copy link
Contributor Author

chingor13 commented Apr 24, 2019

hmm, looks like the new puppycrawl version is not compatible with Java 7

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #5003 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5003      +/-   ##
============================================
- Coverage     50.32%   50.01%   -0.31%     
+ Complexity    23668    22300    -1368     
============================================
  Files          2238     2238              
  Lines        226059   221399    -4660     
  Branches      24959    24847     -112     
============================================
- Hits         113754   110734    -3020     
+ Misses       103704   102945     -759     
+ Partials       8601     7720     -881
Impacted Files Coverage Δ Complexity Δ
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
... and 518 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95a223...7b0ffc3. Read the comment docs.

@chingor13
Copy link
Contributor Author

chingor13 commented Apr 26, 2019

cc @JustinBeckwith

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 30, 2019
@kolea2 kolea2 merged commit cda0b03 into googleapis:master May 1, 2019
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13 @kolea2 @googlebot @yoshi-automation