Skip to content

Include user project in seemsLikeADirectoryAndUsePseudoDirectories #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 6 commits into from
Apr 25, 2019
Merged

Include user project in seemsLikeADirectoryAndUsePseudoDirectories #4996

JesseLovelace merged 6 commits into from
Apr 25, 2019

Conversation

@JesseLovelace
Copy link
Contributor

@JesseLovelace JesseLovelace commented Apr 22, 2019

Fixes #4960

seemsLikeADirectoryAndUsePseudoDirectories wasn't including the user project during a list call, which breaks for requester pays buckets.

@JesseLovelace JesseLovelace requested a review from frankyn April 22, 2019 22:55
@JesseLovelace JesseLovelace requested a review from a team as a code owner April 22, 2019 22:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2019
@JesseLovelace JesseLovelace mentioned this pull request Apr 22, 2019
Closed
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
chingor13
chingor13 reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding an integration test for this?

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9b17a44). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4996   +/-   ##
=========================================
  Coverage          ?   50.32%           
  Complexity        ?    23678           
=========================================
  Files             ?     2238           
  Lines             ?   226079           
  Branches          ?    24966           
=========================================
  Hits              ?   113784           
  Misses            ?   103688           
  Partials          ?     8607
Impacted Files Coverage Δ Complexity Δ
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 63.72% <100%> (ø) 41 <0> (?)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <50%> (ø) 51 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b17a44...967cf96. Read the comment docs.

@JesseLovelace JesseLovelace merged commit 902874f into master Apr 25, 2019
@sduskis sduskis deleted the includeuserproj branch May 1, 2019 17:39
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 left review comments

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google-cloud-nio: calling Files.exists(path) on a non-existing object in a requester pays bucket throws an exception

6 participants

@JesseLovelace @chingor13 @frankyn @sduskis @googlebot @yoshi-kokoro