Fix javadoc linking #4995
Merged
Fix javadoc linking #4995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4995 +/- ##
=========================================
Coverage 50.32% 50.32%
Complexity 23668 23668
=========================================
Files 2238 2238
Lines 226059 226059
Branches 24959 24959
=========================================
Hits 113754 113754
Misses 103704 103704
Partials 8601 8601Continue to review full report at Codecov.
|
Contributor
|
Should we add something to new_client.py for when we generate to add this to the pom.xmls? |
Contributor
Author
Yeah, I'll add it to the template. |
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
approved these changes
Apr 23, 2019
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* Cleanup maven-javadoc-plugin configs * Link proto artifact javadoc to protobuf javadocs * offlineLink from grpc->proto artifact * common protos link * Move common links to the parent * google-cloud client can link to multiple proto/grpc artifact docs * Move protolinks to parent * Configure all grpc->proto artifact offline links * Add offline links for all google-cloud-x clients to the proto/grpc artifacts * Fix dataproc artifact version * Make google-cloud-clients link to google-api-grpc docs * Put groups config back * Put versions variables back * Build the javadoc artifact for release * Add javadoc link config to new_client.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maven configs to correctly link javadoc from google-cloud-clients to google-api-grpc classes.