Skip to content

Bigtable: Added unit tests for GCRule#fromProto #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Apr 24, 2019
Merged

Bigtable: Added unit tests for GCRule#fromProto #4990

chingor13 merged 2 commits into from
Apr 24, 2019

Conversation

@rahulKQL
Copy link

@rahulKQL rahulKQL commented Apr 22, 2019

Fixes #4057

Observation:

If used multiple setXXX() on protobuf GcRule#Builder then the last most added value would be persisted after the build(). This is also valid for model GCRule#fromProto.

Added few unit test cases around the fromProto operation.

@rahulKQL
Bigtable: Added unit tests for GCRule#fromProto
b77dd8a 
Bigtable: Added unit tests for `GCRule#fromProto`.

Observation: If used multiple `setXXX()` on protobuf `GcRule#Builder` then the last most added values would be persisted.
@rahulKQL rahulKQL requested a review from a team as a code owner April 22, 2019 12:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2019
@rahulKQL
Copy link
Author

rahulKQL commented Apr 22, 2019

@sduskis / @igorbernstein2
Please have a look at the observations, If valid then we can close the mentioned issue.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2019
@sduskis sduskis requested review from igorbernstein2 and removed request for a team April 22, 2019 17:12
@igorbernstein2
Copy link

igorbernstein2 commented Apr 23, 2019

The proto uses a one-of for max age & max versions, so you can't set both. This confuses a lot of people, which is one of the reasons we created this wrapper

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4990 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4990      +/-   ##
============================================
- Coverage     50.32%   49.68%   -0.64%     
+ Complexity    23668    22304    -1364     
============================================
  Files          2238     2238              
  Lines        226059   221344    -4715     
  Branches      24959    24079     -880     
============================================
- Hits         113754   109968    -3786     
+ Misses       103704   102914     -790     
+ Partials       8601     8462     -139
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 541 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bc33f...e23a5d5. Read the comment docs.

igorbernstein2
igorbernstein2 approved these changes Apr 23, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@chingor13 chingor13 merged commit 54d1b1c into googleapis:master Apr 24, 2019
@chingor13 chingor13 mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigtable: investigate GCRule.fromProto being incorrect

6 participants

@rahulKQL @igorbernstein2 @chingor13 @sduskis @googlebot @yoshi-kokoro