Skip to content

Refactoring Publisher.publishOutstandingBatch #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
Apr 18, 2019
Merged

Refactoring Publisher.publishOutstandingBatch #4977

sduskis merged 2 commits into from
Apr 18, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 18, 2019

This will make the class look more like the ordering keys changes

@sduskis
Refactoring Publisher.publishOutstandingBatch
09b982a 
This will make the class look more like the ordering keys changes
@sduskis sduskis requested a review from a team as a code owner April 18, 2019 11:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #4977 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4977   +/-   ##
=========================================
  Coverage     50.32%   50.32%           
- Complexity    23665    23666    +1     
=========================================
  Files          2238     2238           
  Lines        226045   226045           
  Branches      24957    24957           
=========================================
  Hits         113751   113751           
  Misses       103697   103697           
  Partials       8597     8597
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 82.47% <100%> (ø) 27 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909d094...c402107. Read the comment docs.

olavloite
olavloite approved these changes Apr 18, 2019
View reviewed changes
Copy link

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduskis sduskis merged commit 8894854 into googleapis:master Apr 18, 2019
@sduskis sduskis deleted the generics_publisher branch April 22, 2019 22:16
@chingor13 chingor13 mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@olavloite olavloite olavloite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @olavloite @googlebot