Skip to content

Prep version numbers for Speech GA. #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Apr 17, 2019
Merged

Prep version numbers for Speech GA. #4970

kolea2 merged 1 commit into from
Apr 17, 2019

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Apr 17, 2019 •
edited
Loading

Fixes #4915

@kolea2 kolea2 requested a review from a team as a code owner April 17, 2019 16:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2019
@kolea2
Copy link
Contributor Author

kolea2 commented Apr 17, 2019

@crwilcox FYI

@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #4970 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4970      +/-   ##
============================================
- Coverage     50.32%   49.67%   -0.65%     
+ Complexity    23666    22299    -1367     
============================================
  Files          2238     2238              
  Lines        226045   221333    -4712     
  Branches      24957    24079     -878     
============================================
- Hits         113753   109947    -3806     
+ Misses       103696   102931     -765     
+ Partials       8596     8455     -141
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/testing/CommandWrapper.java 90.9% <0%> (-6.07%) 13% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 61.98% <0%> (-3.06%) 9% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
... and 542 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98eeb9d...6193976. Read the comment docs.

@kolea2 kolea2 merged commit 644cd79 into googleapis:master Apr 17, 2019
@kolea2 kolea2 deleted the speech-ga branch April 17, 2019 17:28
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google-cloud-speech should be promoted to GA

4 participants

@kolea2 @chingor13 @crwilcox @googlebot