Skip to content

Bigquery: Fix bug for ProjectId in listTableData. #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 25, 2019
Merged

Bigquery: Fix bug for ProjectId in listTableData. #4965

sduskis merged 1 commit into from
Apr 25, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Apr 17, 2019

Fixes #4934

@pmakani pmakani requested a review from a team as a code owner April 17, 2019 12:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2019
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #4965 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4965      +/-   ##
============================================
- Coverage     50.36%   50.36%   -0.01%     
  Complexity    23666    23666              
============================================
  Files          2232     2232              
  Lines        225859   225859              
  Branches      24956    24956              
============================================
- Hits         113753   113752       -1     
- Misses       103510   103511       +1     
  Partials       8596     8596
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 84.09% <100%> (+0.25%) 53 <0> (+1) ⬆️
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10070bd...d57f375. Read the comment docs.

@sduskis sduskis requested a review from shollyman April 17, 2019 15:35
@sduskis
Copy link
Contributor

sduskis commented Apr 17, 2019

@shollyman, this looks good to me. What do you think?

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 24, 2019
@sduskis
Copy link
Contributor

sduskis commented Apr 25, 2019

@shollyman, ping

shollyman
shollyman approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@sduskis sduskis merged commit 264643d into googleapis:master Apr 25, 2019
@pmakani pmakani deleted the api-bigquery-bug-4934 branch April 29, 2019 06:24
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.google.cloud.bigquery.Job.getQueryResults fails on job that writes to destination table in different project

5 participants

@pmakani @sduskis @shollyman @googlebot @yoshi-automation