Initial Generation of data catalog #4957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kolea2
reviewed
Apr 16, 2019
google-api-grpc/pom.xml
Outdated
| <module>grpc-google-cloud-container-v1</module> | ||
| <module>grpc-google-cloud-containeranalysis-v1beta1</module> | ||
| <module>grpc-google-cloud-datalabeling-v1beta1</module> | ||
| <module>grpc-google-cloud-datacatalog-v1beta1</module><module>grpc-google-cloud-datalabeling-v1beta1</module> |
kolea2
reviewed
Apr 16, 2019
google-api-grpc/pom.xml
Outdated
| <module>proto-google-cloud-container-v1</module> | ||
| <module>proto-google-cloud-containeranalysis-v1beta1</module> | ||
| <module>proto-google-cloud-datalabeling-v1beta1</module> | ||
| <module>proto-google-cloud-datacatalog-v1beta1</module><module>proto-google-cloud-datalabeling-v1beta1</module> |
kolea2
suggested changes
Apr 16, 2019
kolea2
reviewed
Apr 16, 2019
google-cloud-bom/pom.xml
Outdated
| <version>0.2.1-alpha-SNAPSHOT</version><!--{x-version-update:google-cloud-webrisk:current}--> | ||
| </dependency> | ||
| </dependencies> | ||
| <dependency><groupId>com.google.api.grpc</groupId><artifactId>proto-google-cloud-datacatalog-v1beta1</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:proto-google-cloud-datacatalog-v1beta1:current}--></dependency><dependency><groupId>com.google.api.grpc</groupId><artifactId>grpc-google-cloud-datacatalog-v1beta1</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:grpc-google-cloud-datacatalog-v1beta1:current}--></dependency><dependency><groupId>com.google.cloud</groupId><artifactId>google-cloud-datacatalog</artifactId><version>0.0.1-alpha-SNAPSHOT</version><!--{x-version-update:google-cloud-datacatalog:current}--></dependency></dependencies> |
Contributor
Author
|
@kolea2, this should be ready to go. |
Codecov Report
@@ Coverage Diff @@
## master #4957 +/- ##
============================================
- Coverage 50.36% 50.32% -0.04%
Complexity 23665 23665
============================================
Files 2233 2238 +5
Lines 225856 226045 +189
Branches 24956 24957 +1
============================================
+ Hits 113742 113751 +9
- Misses 103517 103697 +180
Partials 8597 8597
Continue to review full report at Codecov.
|
kolea2
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.