Spanner: Aborted batch dml should be retried #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing batchDml statements, it is possible that the transaction is aborted by Spanner for one of the statements. This used to throw a SpannerBatchUpdateException, which would cause the transaction to fail, while the appropriate exception is AbortedException to trigger a retry of the transaction.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4955 +/- ##
============================================
- Coverage 50.36% 49.98% -0.38%
- Complexity 23665 23668 +3
============================================
Files 2233 2238 +5
Lines 225856 226007 +151
Branches 24956 24191 -765
============================================
- Hits 113742 112974 -768
- Misses 103517 103693 +176
- Partials 8597 9340 +743
Continue to review full report at Codecov.
|
kolea2
reviewed
Apr 16, 2019
...ients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java
Show resolved
Hide resolved
sduskis
reviewed
Apr 18, 2019
| exception = e; | ||
| updateCount = e.getUpdateCounts(); | ||
| } | ||
| if (status == Code.ABORTED_VALUE) { |
Contributor
There was a problem hiding this comment.
Is there anyway to move the asserts into batchDmlAborted and batchDmlFailedPrecondition?
kolea2
approved these changes
Apr 19, 2019
Contributor
|
@olavloite LGTM after running code formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing batchDml statements, it is possible that the transaction is aborted by Spanner for one of the statements. This used to throw a SpannerBatchUpdateException, which would cause the transaction to fail, while the appropriate exception is AbortedException to trigger a retry of the transaction.