Skip to content

Use splitindex for google-api-grpc javadoc. #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Apr 16, 2019
Merged

Use splitindex for google-api-grpc javadoc. #4952

kolea2 merged 1 commit into from
Apr 16, 2019

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Apr 15, 2019

No description provided.

@kolea2 kolea2 requested a review from a team as a code owner April 15, 2019 18:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@kolea2
Copy link
Contributor Author

kolea2 commented Apr 15, 2019

@chingor13 PTAL

@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #4952 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4952      +/-   ##
============================================
- Coverage     50.36%   50.02%   -0.34%     
  Complexity    23666    23666              
============================================
  Files          2233     2233              
  Lines        225860   225808      -52     
  Branches      24956    24190     -766     
============================================
- Hits         113744   112966     -778     
+ Misses       103519   103508      -11     
- Partials       8597     9334     +737
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.95% <0%> (-6.46%) 139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 48.92% <0%> (-5.76%) 35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7ece5...8d6c41c. Read the comment docs.

@chingor13
Copy link
Contributor

chingor13 commented Apr 15, 2019

Should we do it for google-cloud-clients as well?

@kolea2 kolea2 merged commit a2741ae into googleapis:master Apr 16, 2019
@kolea2 kolea2 deleted the javadoc-index branch April 16, 2019 17:10
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kolea2 @chingor13 @sduskis @googlebot