Skip to content

Cleaning up deprecated pubsub code. #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 3 commits into from
Apr 16, 2019
Merged

Cleaning up deprecated pubsub code. #4949

sduskis merged 3 commits into from
Apr 16, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 15, 2019

No description provided.

@sduskis sduskis requested a review from a team as a code owner April 15, 2019 14:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2fc4e55). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4949   +/-   ##
=========================================
  Coverage          ?   50.36%           
  Complexity        ?    23674           
=========================================
  Files             ?     2233           
  Lines             ?   225860           
  Branches          ?    24952           
=========================================
  Hits              ?   113744           
  Misses            ?   103519           
  Partials          ?     8597
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 64.75% <0%> (ø) 9 <0> (?)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.56% <100%> (ø) 22 <2> (?)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 81.05% <100%> (ø) 26 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc4e55...8bbefbe. Read the comment docs.

@kolea2 kolea2 mentioned this pull request Apr 15, 2019
Merged
@sduskis sduskis merged commit e5e7a21 into googleapis:master Apr 16, 2019
@sduskis sduskis deleted the cleanup_pubsub_4 branch April 16, 2019 14:59
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @kolea2 @googlebot