Skip to content

Minor cleanup in pubsub #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
Apr 15, 2019
Merged

Minor cleanup in pubsub #4945

sduskis merged 2 commits into from
Apr 15, 2019

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 15, 2019

  • MessageDispatcher methods get reduced scope
  • Cleaning up MessageWaiter by removing test code

@sduskis
Minor cleanup in pubsub
f40edff 
- MessageDispatcher methods get reduced scope
- Cleaning up MessageWaiter by removing test code
@sduskis sduskis requested a review from a team as a code owner April 15, 2019 13:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@sduskis sduskis merged commit 2fc4e55 into googleapis:master Apr 15, 2019
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
@sduskis sduskis deleted the cleanup_pubsub_1 branch April 22, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @kolea2 @googlebot