Skip to content

CSCC Snippets #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 10 commits into from
Apr 15, 2019
Merged

CSCC Snippets #4917

sduskis merged 10 commits into from
Apr 15, 2019

Conversation

@emkornfield
Copy link

@emkornfield emkornfield commented Apr 5, 2019

Add remaining snippets for CSCC

@emkornfield emkornfield requested a review from a team as a code owner April 5, 2019 21:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019 •
edited
Loading

Codecov Report

Merging #4917 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4917      +/-   ##
============================================
- Coverage     50.35%   49.71%   -0.64%     
+ Complexity    23618    22300    -1318     
============================================
  Files          2231     2233       +2     
  Lines        225686   221150    -4536     
  Branches      24929    24078     -851     
============================================
- Hits         113634   109945    -3689     
+ Misses       103463   102750     -713     
+ Partials       8589     8455     -134
Impacted Files Coverage Δ Complexity Δ
...ava/com/google/cloud/storage/BlobWriteChannel.java 71.66% <0%> (-19.51%) 9% <0%> (+4%)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 547 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167ed3...2813fee. Read the comment docs.

@emkornfield emkornfield requested a review from sduskis April 8, 2019 18:41
@sduskis
Copy link
Contributor

sduskis commented Apr 11, 2019

@emkornfield, you need to run mvn com.coveo:fmt-maven-plugin:format again.

@emkornfield
Copy link
Author

emkornfield commented Apr 11, 2019

Sorry about that. done.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 12, 2019
sduskis
sduskis approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@sduskis sduskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a small fix. Please address it before merging.

...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java Outdated
}
}
// [END list_asset_changes_status_changes]
// [END list_asset_changes_status_changes]\
Copy link
Contributor

@sduskis sduskis Apr 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing \

@sduskis sduskis merged commit aace1e5 into master Apr 15, 2019
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
@sduskis sduskis deleted the cscc_examples branch May 1, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emkornfield @sduskis @googlebot @yoshi-automation