Skip to content

Spanner: Refactor SpannerImpl - Move SessionImpl to separate file #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 4 commits into from
Apr 15, 2019
Merged

Spanner: Refactor SpannerImpl - Move SessionImpl to separate file #4895

kolea2 merged 4 commits into from
Apr 15, 2019

Conversation

@olavloite
Copy link

@olavloite olavloite commented Apr 3, 2019

Move SessionImpl from SpannerImpl to a separate class file.

@olavloite olavloite requested a review from a team as a code owner April 3, 2019 11:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #4895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4895   +/-   ##
=========================================
  Coverage     50.35%   50.35%           
  Complexity    23639    23639           
=========================================
  Files          2231     2231           
  Lines        225723   225723           
  Branches      24935    24935           
=========================================
  Hits         113674   113674           
  Misses       103462   103462           
  Partials       8587     8587
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java 41.48% <0%> (ø) 27% <0%> (ø) ⬇️
...om/google/cloud/logging/MonitoredResourceUtil.java 50.92% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47884a3...bab1cca. Read the comment docs.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@olavloite olavloite force-pushed the spanner-refactor-spannerimpl-sessionimpl branch from fa1c0ad to 03d284e Compare April 6, 2019 09:25
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 10, 2019
@sduskis sduskis requested review from kolea2 and removed request for a team April 11, 2019 15:32
@olavloite olavloite mentioned this pull request Apr 11, 2019
Merged
@olavloite olavloite force-pushed the spanner-refactor-spannerimpl-sessionimpl branch from 03d284e to bab1cca Compare April 12, 2019 05:38
@kolea2 kolea2 merged commit be7ece5 into googleapis:master Apr 15, 2019
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@olavloite @sduskis @googlebot @yoshi-automation @yoshi-kokoro @kolea2