Skip to content

Regenerate kms client #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Feb 26, 2019
Merged

Regenerate kms client #4570

sduskis merged 1 commit into from
Feb 26, 2019

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Feb 26, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-kms/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:f3d61ae45abaeefb6be5f228cda22732c2f1b00fb687c79c4bd4f2c42bb1e1a7
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/kms/artman_cloudkms.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 13 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 79 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team as a code owner February 26, 2019 08:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 26, 2019

It looks like Bigtable has a flaky unit test (FYI @igorbernstein2):

[ERROR] ReadRowsRetryTest.pointTest » IllegalState call was cancelled

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 26, 2019

last time kokoro ran, Java 11 failed. This time java 8 windows:

[ERROR] errorAtTheVeryEndTest(com.google.cloud.bigquery.storage.v1beta1.stub.readrows.ReadRowsRetryTest) Time elapsed: 0.038 s <<< ERROR!
java.lang.NullPointerException
at com.google.cloud.bigquery.storage.v1beta1.stub.readrows.ReadRowsRetryTest.getRowCount(ReadRowsRetryTest.java:179)
at com.google.cloud.bigquery.storage.v1beta1.stub.readrows.ReadRowsRetryTest.errorAtTheVeryEndTest(ReadRowsRetryTest.java:173)

The failures are disturbing, but unrelated to change.

@sduskis sduskis merged commit 266c880 into master Feb 26, 2019
@kolea2 kolea2 mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @sduskis @googlebot @yoshi-kokoro