[cloud spanner] Add dependency for surefire-junit47 #4526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Author
|
@silverdev, @snehashah16, @nithinsujir, @kolea2 for FYI |
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #4526 +/- ##
============================================
- Coverage 49.15% 49.15% -0.01%
Complexity 21934 21934
============================================
Files 2077 2077
Lines 207174 207174
Branches 24099 24099
============================================
- Hits 101841 101838 -3
- Misses 97160 97163 +3
Partials 8173 8173
Continue to review full report at Codecov.
|
Contributor
|
Is this something we should apply for all projects? |
Author
|
I think this was only missing for spanner. For example, bigtable has a clause for this: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/pom.xml#L134 |
sduskis
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes junit dependency issue when running tests in a VPC.