Skip to content

Add KMS IT test and kokoro configs. #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 2 commits into from
Feb 19, 2019
Merged

Add KMS IT test and kokoro configs. #4517

kolea2 merged 2 commits into from
Feb 19, 2019

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Feb 19, 2019

No description provided.

@kolea2 kolea2 requested a review from a team as a code owner February 19, 2019 19:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #4517 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4517      +/-   ##
============================================
- Coverage     49.16%   48.52%   -0.64%     
+ Complexity    21929    20734    -1195     
============================================
  Files          2077     2077              
  Lines        207074   202981    -4093     
  Branches      24097    23292     -805     
============================================
- Hits         101801    98490    -3311     
+ Misses        97100    96416     -684     
+ Partials       8173     8075      -98
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/MonitoredResourceUtil.java 41.66% <0%> (-9.26%) 5% <0%> (-3%)
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java 80% <0%> (-4.62%) 14% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
... and 485 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344fdac...ce85b46. Read the comment docs.

@kolea2 kolea2 mentioned this pull request Feb 19, 2019
Merged
@kolea2 kolea2 merged commit f0efbe9 into googleapis:master Feb 19, 2019
@kolea2 kolea2 deleted the kms-it-config branch February 19, 2019 20:44
@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2 @sduskis @googlebot