Skip to content

Datastore: Fix more_results value to query results #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 4 commits into from
Feb 21, 2019
Merged

Datastore: Fix more_results value to query results #4516

sduskis merged 4 commits into from
Feb 21, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Feb 19, 2019

Fixes #4504

@pmakani pmakani requested a review from a team as a code owner February 19, 2019 18:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e67981a). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4516   +/-   ##
=========================================
  Coverage          ?   48.84%           
  Complexity        ?    21947           
=========================================
  Files             ?     2077           
  Lines             ?   207098           
  Branches          ?    23429           
=========================================
  Hits              ?   101153           
  Misses            ?    97098           
  Partials          ?     8847
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/datastore/QueryResultsImpl.java 88.23% <66.66%> (ø) 17 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67981a...ff2f1ef. Read the comment docs.

sduskis
sduskis reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@sduskis sduskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for the getter.

@sduskis sduskis added the api: datastore Issues related to the Datastore API. label Feb 20, 2019
@pmakani
Copy link
Author

pmakani commented Feb 21, 2019

Done.

@sduskis sduskis merged commit a1679e4 into googleapis:master Feb 21, 2019
@mtso
Copy link

mtso commented Feb 21, 2019

Thank you!

@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
@pmakani pmakani deleted the api-datastore-4504 branch February 25, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmakani @mtso @sduskis @googlebot @yoshi-kokoro