Bigtable: Deemphasize most of the settings and move them to the StubSettings #4509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4509 +/- ##
=========================================
Coverage ? 49.15%
Complexity ? 21929
=========================================
Files ? 2077
Lines ? 207109
Branches ? 24097
=========================================
Hits ? 101804
Misses ? 97132
Partials ? 8173
Continue to review full report at Codecov.
|
…ettings This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings
igorbernstein2
force-pushed
the
settings--5
branch
from
d787160 to
0fae43f
Compare
# Conflicts: # google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sduskis
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings
Extracted from #4498