Skip to content

Bigtable: add a helper method to easily connect to an emulator #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 6 commits into from
Feb 20, 2019
Merged

Bigtable: add a helper method to easily connect to an emulator #4506

igorbernstein2 merged 6 commits into from
Feb 20, 2019

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Feb 15, 2019

Extracted from #4498

@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2019
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner February 15, 2019 19:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@igorbernstein2 igorbernstein2 mentioned this pull request Feb 15, 2019
Closed
@igorbernstein2
Merge remote-tracking branch 'origin/master' into settings-2
c66c089 
# Conflicts:
#	google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java
#	google-cloud-testing/google-cloud-bigtable-emulator/README.md
@codecov
Copy link

codecov bot commented Feb 17, 2019 •
edited
Loading

Codecov Report

Merging #4506 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4506      +/-   ##
============================================
- Coverage     49.16%   49.15%   -0.01%     
  Complexity    21929    21929              
============================================
  Files          2077     2077              
  Lines        207074   207103      +29     
  Branches      24097    24097              
============================================
- Hits         101801   101795       -6     
- Misses        97100    97135      +35     
  Partials       8173     8173
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 24.52% <0%> (-10.61%) 3 <0> (ø)
.../bigtable/admin/v2/BigtableTableAdminSettings.java 69.04% <0%> (-30.96%) 6 <0> (ø)
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java 80% <0%> (-4.62%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344fdac...5f033ea. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit e6cf8d3 into googleapis:master Feb 20, 2019
@igorbernstein2 igorbernstein2 deleted the settings-2 branch February 20, 2019 15:25
@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @sduskis @googlebot