Skip to content

Bump gax-java dependency #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 4 commits into from
Feb 15, 2019
Merged

Bump gax-java dependency #4496

sduskis merged 4 commits into from
Feb 15, 2019

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 14, 2019 •
edited
Loading

To keep the same common-protos dependency at 1.14.0 as in #4486

@andreamlin andreamlin requested a review from a team as a code owner February 14, 2019 20:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019
@andreamlin andreamlin requested a review from kolea2 February 14, 2019 20:35
@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 14, 2019

PTAL

@sduskis
Copy link
Contributor

sduskis commented Feb 14, 2019

Can you please upgrade the other dependencies that changed in gax? (I know that at least grpc and opencensus were upgraded)

@sduskis
Copy link
Contributor

sduskis commented Feb 14, 2019

Should we update common proto here instead of #4486?

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 14, 2019

Ok, also updated the common protos dep

@sduskis
Copy link
Contributor

sduskis commented Feb 14, 2019

Sorry to do this... google-api-grpc also has grpc dependencies (and maybe others?) that also need to be update.

After this exercise we should consider moving common properties up to the root pom.

@sduskis
Copy link
Contributor

sduskis commented Feb 14, 2019 •
edited
Loading

It looks like there is a convergence issue:

[ERROR] Failed to execute goal on project google-cloud-examples: Could not resolve dependencies for project com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Failed to collect dependencies for com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Could not resolve version conflict among [

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT -> 
        com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-protobuf:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,
 
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-protobuf:jar:1.18.0 ->
        io.grpc:grpc-protobuf-lite:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        io.grpc:grpc-stub:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        io.grpc:grpc-auth:jar:1.18.0 ->
        io.grpc:grpc-core:jar:[1.18.0,1.18.0],

com.google.cloud:google-cloud-datastore:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-netty-shaded:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-alts:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-alts:jar:1.17.1 ->
        io.grpc:grpc-grpclb:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-spanner:jar:1.7.1-SNAPSHOT ->
        io.opencensus:opencensus-contrib-grpc-util:jar:0.18.0 ->
        io.grpc:grpc-core:jar:1.14.0] ->

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 15, 2019

@sduskis is it ok now? i just forgot to bump google-cloud-logging's dep on gax

@sduskis sduskis merged commit 0165145 into googleapis:master Feb 15, 2019
@andreamlin andreamlin deleted the bump_gax branch February 15, 2019 17:26
@andreamlin andreamlin mentioned this pull request Feb 15, 2019
Closed
@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
@kolea2 kolea2 mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreamlin @sduskis @googlebot