BigQuery: Fix support standard java date in QueryParameterValue classToType #4489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4489 +/- ##
============================================
+ Coverage 49.16% 49.16% +<.01%
- Complexity 21913 21917 +4
============================================
Files 2078 2078
Lines 207048 207059 +11
Branches 24084 24086 +2
============================================
+ Hits 101789 101799 +10
- Misses 97116 97117 +1
Partials 8143 8143
Continue to review full report at Codecov.
|
sduskis
suggested changes
Feb 13, 2019
| DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSS"); | ||
| private static final DateTimeFormatter datetimeFormatter = | ||
| DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss.SSSSSS"); | ||
| private static final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd"); |
Contributor
There was a problem hiding this comment.
Please use DateTimeFormatter instead of the java standard format.
Author
There was a problem hiding this comment.
DateTimeFormatter is only available after java 8.
Author
There was a problem hiding this comment.
Updated to remove formatter and replaced with utility method from google cloud date. Sorry I misread your comment earlier and though of jdk8s datetimeformatter.
pmakani
force-pushed
the
api-bigquery-3589
branch
from
8383bdf to
888fdc6
Compare
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sduskis
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3589 com.google.cloud.bigquery.QueryParameterValue classToType should support standard Java