Skip to content

Regenerate pubsub client #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Feb 14, 2019
Merged

Regenerate pubsub client #4487

sduskis merged 1 commit into from
Feb 14, 2019

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Feb 13, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-pubsub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Replaced 'return InstantiatingGrpcChannelProvider\\.newBuilder\\(\\);' in src/main/java/com/google/cloud/pubsub/v1/stub/SubscriberStubSettings.java.
synthtool > Running java formatter on 43 files
synthtool > Running java formatter on 2 files
synthtool > Running java formatter on 87 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team as a code owner February 13, 2019 08:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #4487 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4487      +/-   ##
============================================
- Coverage     49.16%   49.16%   -0.01%     
  Complexity    21913    21913              
============================================
  Files          2078     2078              
  Lines        207048   207049       +1     
  Branches      24084    24084              
============================================
- Hits         101789   101787       -2     
- Misses        97116    97119       +3     
  Partials       8143     8143
Impacted Files Coverage Δ Complexity Δ
...e/cloud/pubsub/v1/stub/SubscriberStubSettings.java 85.21% <100%> (-0.06%) 28 <0> (ø)
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java 84.06% <100%> (+0.12%) 20 <0> (ø) ⬇️
...gle/cloud/storage/testing/RemoteStorageHelper.java 55.28% <0%> (-2.44%) 8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4ce6c...fd363d1. Read the comment docs.

@sduskis
Copy link
Contributor

sduskis commented Feb 13, 2019

@jadekler, can you please review this one, given the fact that you made the artman config change?

@sduskis sduskis requested review from jeanbza and removed request for a team February 13, 2019 12:42
@sduskis sduskis merged commit 0aab68a into master Feb 14, 2019
@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeanbza jeanbza Awaiting requested review from jeanbza

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @sduskis @googlebot