Skip to content

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Feb 12, 2019

No description provided.

@kolea2 kolea2 requested a review from a team as a code owner February 12, 2019 23:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@kolea2 kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 12, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@kolea2
Copy link
Contributor Author

kolea2 commented Feb 13, 2019

@andreamlin do you know if this needs to be upgraded in gax as well?

@andreamlin
Copy link
Contributor

@kolea2 gax 1.39.0 has this new common protos v1.14.0 now!

@andreamlin
Copy link
Contributor

Hey @kolea2 as part of #4496 it was suggested to also bump the proto-google-common-protos there so we could have the same versions of deps across the board at once.

@sduskis sduskis closed this Feb 15, 2019
@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 19, 2019
@kolea2 kolea2 deleted the proto-upgrade branch March 22, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants