Skip to content

Conversation

@pmakani
Copy link

@pmakani pmakani commented Feb 12, 2019

Fixes #4319 Support for StandardSQLTypeName in Field.newBuilder(name, type).

@pmakani pmakani requested a review from a team as a code owner February 12, 2019 18:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #4483 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4483      +/-   ##
============================================
+ Coverage     49.16%   49.16%   +<.01%     
- Complexity    21913    21917       +4     
============================================
  Files          2078     2078              
  Lines        207048   207059      +11     
  Branches      24084    24088       +4     
============================================
+ Hits         101789   101799      +10     
- Misses        97116    97117       +1     
  Partials       8143     8143
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/bigquery/LegacySQLTypeName.java 94.87% <100%> (+3.69%) 7 <1> (+3) ⬆️
...src/main/java/com/google/cloud/bigquery/Field.java 87.35% <66.66%> (-1.54%) 24 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4ce6c...8d805f5. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 19, 2019
@pmakani
Copy link
Author

pmakani commented Feb 21, 2019

@sduskis PTAL

@sduskis sduskis merged commit 213a56e into googleapis:master Feb 21, 2019
@pmakani pmakani deleted the api-bigquery-4319 branch February 25, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants