[bigtable] Addition of Row#fromProto #4457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sduskis
reviewed
Feb 6, 2019
...lients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Row.java
Outdated
Show resolved
Hide resolved
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
I recently merged: Any particular reason you'd want to have this on the model? |
Contributor
|
We can use #4458 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Row#fromPrototo generatemodels.Rowfrom protobufRow.Would need this feature for translation of model in
BigtableDataClientWrapper, related in GBT-2061.