Set connect/read timeout when calling the metadata service #4413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ajaaym
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Author
|
@ajaaym can you take a look at this pls? |
Contributor
|
@dmichel1, can you please run |
Otherwise callers of these methods can be waiting indefinitely. googleapis#4398
Author
|
@sduskis i rebased and pushed my code again - build should be passing. |
sduskis
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Author
|
Unrelated IT tests are failing for this PR now. |
sduskis
added
the
kokoro:force-run
Contributor
|
I'll try to run the tests again, just to be sure. |
yoshi-kokoro
removed
the
kokoro:force-run
Author
|
@sduskis yaya they are passing now. thanks |
ajaaym
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise callers of these methods can be waiting indefinitely.
Fixes #4398