Skip to content

BigQuery: Fixes When Table,Dataset and Job is not found #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 4 commits into from
Feb 25, 2019
Merged

BigQuery: Fixes When Table,Dataset and Job is not found #4389

sduskis merged 4 commits into from
Feb 25, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Jan 18, 2019

Fixes #3930 getTable(), getDataset() and getJob().

@pmakani pmakani requested a review from a team as a code owner January 18, 2019 11:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2019
sduskis
sduskis suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@sduskis sduskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmakani, can you please resolve the conflicts?

@sduskis sduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
@codecov
Copy link

codecov bot commented Feb 11, 2019 •
edited
Loading

Codecov Report

Merging #4389 into master will decrease coverage by 4.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4389      +/-   ##
============================================
- Coverage     49.19%   45.08%   -4.11%     
- Complexity    21957    25313    +3356     
============================================
  Files          2076     2078       +2     
  Lines        207407   247282   +39875     
  Branches      24108    31911    +7803     
============================================
+ Hits         102030   111491    +9461     
- Misses        97205   126040   +28835     
- Partials       8172     9751    +1579
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.46% <0%> (-0.81%) 49 <0> (ø)
...ava/com/google/cloud/bigquery/BigQueryOptions.java 88.88% <100%> (+1.01%) 11 <2> (+2) ⬆️
...loud/bigtable/data/v2/internal/RequestContext.java 33.33% <0%> (-66.67%) 2% <0%> (ø)
...gtable/admin/v2/BigtableInstanceAdminSettings.java 82.14% <0%> (-17.86%) 5% <0%> (-1%)
...com/google/cloud/bigquery/QueryParameterValue.java 65.32% <0%> (-7.05%) 43% <0%> (-3%)
...va/com/google/cloud/redis/v1/CloudRedisClient.java 53.93% <0%> (-6.07%) 23% <0%> (-12%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 93.19% <0%> (-5.37%) 15% <0%> (-2%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 84.31% <0%> (-5.27%) 32% <0%> (ø)
...a/com/google/cloud/bigquery/LegacySQLTypeName.java 91.17% <0%> (-3.95%) 4% <0%> (-3%)
...1/TargetHttpsProxiesSetSslCertificatesRequest.java 19.48% <0%> (-3.93%) 7% <0%> (+2%)
... and 794 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e0f2f...9096224. Read the comment docs.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@sduskis sduskis removed the status: blocked Resolving the issue is dependent on other work. label Feb 20, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 20, 2019
@pmakani
Copy link
Author

pmakani commented Feb 25, 2019

@sduskis PTAL.

@sduskis sduskis merged commit 786ce15 into googleapis:master Feb 25, 2019
@pmakani pmakani deleted the api-bigquery-3930 branch February 25, 2019 15:56
@kolea2 kolea2 mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmakani @sduskis @googlebot @yoshi-automation @yoshi-kokoro