Skip to content

Conversation

@andrey-qlogic
Copy link

@andrey-qlogic andrey-qlogic commented Dec 31, 2018

…e from META-INF/services

Fixes #3540

@andrey-qlogic andrey-qlogic requested a review from a team as a code owner December 31, 2018 14:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 31, 2018
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 31, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 31, 2018
javabrown and others added 11 commits December 31, 2018 12:35
…oogleapis#4263)

* Fixed Issue - shutting-down WatchDog daemon threads spawned by Spanner client

* Fixed Issue - shutdown watchDog daemon threads spawned by Spanner client

* Minor code formatting

* Fixed Kokoro code format issue
* Fix Kokoro release jobs. Needs loopback pinentry-mode

* Skip install on deploy

* skip stagingProfileId

* Capture built artifacts

* Enable promote/drop jobs via environment variable

* Fix directory path and use -B for drop/release

* promote/drop need the settings file

* Fix path to settings file

* Update RELEASING documentation to use the Kokoro jobs
* add abandonment

* add unit test for abandon

* update forget() to stop extending deadline
* Fix Maximum Bytes Billed

* remove whitespace
…#4254)

* fix googleapis#3880 googleapis#2796 disable automatic flush on write to avoid hanging and leaking threads as grpc also uses this appender which goes in to deadlock over time.

* fix formatting

* add flush before listing
The configuration for aggregate changed from an attribute to a report
* Bigtable: deprecate the use of typesafe names

Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative

* fix docs

* format code
* modified package-private to public

* update format for storage/Option.java
* Fix NumBytes and NumRows

* update NumBytes and NumRows

* remove setter

* update methods and resolved test case
* helloWorld sample

* test class modified

* format change in ITHelloWorld
@yihanzhen
Copy link
Contributor

I think the idea is to have the classes under META-INF/services point to the shaded versions instead of filtering them out. E.g., com.fasterxml.jackson.core.JsonFactory should be shaded.cloud_nio.com.fasterxml.jackson.core.JsonFactory instead.

@andrey-qlogic
Copy link
Author

I think the idea is to have the classes under META-INF/services point to the shaded versions instead of filtering them out. E.g., com.fasterxml.jackson.core.JsonFactory should be shaded.cloud_nio.com.fasterxml.jackson.core.JsonFactory instead.

Why do we need those 2 classes in META-INF/services?

@igorbernstein2
Copy link

@andrey-qlogic
Copy link
Author

@igorbernstein2 , thanks for the hint. Changed.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
Copy link
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yoshi-automation and others added 9 commits January 4, 2019 13:53
* Bigtable admin: deprecate typesafe names

This is a followup on googleapis#4257:
Unfortunately typesafe names create more issues for bigtable than they solve. A lot of the time users need to use both bigtable data & admin apis. Unfortunately, those apis define the same names in different namespaces. This forces users to use fully qualified names which is ugly. Also, absolute names don't benefit the bigtable client because the client is anchored at the instance and all names end up being relative

* format code

* fix year
* updated links

* updated link

* added new line
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 8, 2019
@andrey-qlogic andrey-qlogic deleted the 3540 branch January 8, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.