Bigtable data client comment update #3833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. LGTM, but please remove the exists() code
| } | ||
| }, MoreExecutors.directExecutor()); | ||
| } | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
elisheva-qlogic
force-pushed
the
BigtableDataClient_comment_update
branch
from
9e04a1e to
2863e50
Compare
igorbernstein2
approved these changes
Oct 22, 2018
sduskis
approved these changes
Oct 23, 2018
igorbernstein2
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815
Updated comments in:
BigtableInstanceAdminClient
BigtableTableAdminClient
BigtableDataClient