Skip to content

Update CODEOWNERS. #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Oct 18, 2018
Merged

Update CODEOWNERS. #3831

chingor13 merged 1 commit into from
Oct 18, 2018

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 17, 2018

@chingor13
Update CODEOWNERS.
7367503 
- Remove @vam-google
- Remove @andreamlin from all but Compute
- Fix path prefix
@chingor13 chingor13 requested a review from andreamlin October 17, 2018 22:20
@chingor13 chingor13 requested a review from a team as a code owner October 17, 2018 22:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
@chingor13
Copy link
Contributor Author

chingor13 commented Oct 17, 2018

cc @vam-google as they somehow don't have write access so I can't request a review.

@vam-google
Copy link
Contributor

vam-google commented Oct 17, 2018

@chingor13 that is weird... I created this CODEOWNERS file. Are you sure I don't have the permissions? If I do not, then I was somehow removed by mistake. Pleaese add me back

@vam-google vam-google self-requested a review October 17, 2018 23:51
vam-google
vam-google approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13
Copy link
Contributor Author

chingor13 commented Oct 17, 2018

@vam-google Permissions were all weird after this repo moved orgs.

andreamlin
andreamlin approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 865e255 into googleapis:master Oct 18, 2018
@chingor13 chingor13 deleted the update-codeowners branch October 18, 2018 00:04
@JesseLovelace JesseLovelace mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@andreamlin andreamlin andreamlin approved these changes

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13 @vam-google @andreamlin @googlebot