Skip to content

Conversation

@chingor13
Copy link
Contributor

Adds compute library synth file which uses the discogapic generator.

Added to synthtool in https://github.com/googleapis/synthtool/releases/tag/synthtool-0.10.0

@chingor13 chingor13 requested a review from andreamlin October 17, 2018 20:02
@chingor13 chingor13 requested a review from a team as a code owner October 17, 2018 20:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
@andreamlin
Copy link
Contributor

Has this been tested?

@chingor13
Copy link
Contributor Author

These are only really testable by cd'ing to the directory and running python3 synth.py (assuming synthtool is already installed). This has been tested locally and there is a documentation change pending which will appear tomorrow assuming this is merged.

import synthtool.gcp as gcp

gapic = gcp.DiscoGAPICGenerator()
common_templates = gcp.CommonTemplates()

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 72f7bed into googleapis:master Oct 18, 2018
@chingor13 chingor13 deleted the compute-synth branch October 18, 2018 00:09
@JesseLovelace JesseLovelace mentioned this pull request Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants