Make testDownloadPublicBlobWithoutAuthentication skippable with an environment variable #3828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
reviewed
Oct 16, 2018
...ud-clients/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java
Outdated
Show resolved
Hide resolved
…vironment variable
…gle-cloud-java into useenvironmentvariable
frankyn
suggested changes
Oct 16, 2018
| private static final String KMS_KEY_RING_LOCATION = "us"; | ||
| private static final String KMS_KEY_ONE_NAME = "gcs_kms_key_one"; | ||
| private static final String KMS_KEY_TWO_NAME = "gcs_kms_key_two"; | ||
| private static final boolean isVpcTest = System.getenv("GOOGLE_CLOUD_TESTS_IN_VPCSC").equalsIgnoreCase("true"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…gle-cloud-java into useenvironmentvariable
…gle-cloud-java into useenvironmentvariable
frankyn
approved these changes
Oct 16, 2018
…gle-cloud-java into useenvironmentvariable
…gle-cloud-java into useenvironmentvariable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testDownloadPublicBlobWithoutAuthentication will never pass when running in a restricted VPC, so this gives the option to skip to skip the test by setting the environment variable GOOGLE_CLOUD_TESTS_IN_VPCSC to "true".
This replaces the solution of skipping the test if there's any 403, since that could be a genuine error.