Add assumptions to storage integration tests #3813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
suggested changes
Oct 12, 2018
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Overall looks good just two minor nits.
| bytes = unauthorizedStorage.readAllBytes(landsatBucket, landsatBlob); | ||
| } catch (StorageException ex) { | ||
| assertTrue(ex.getCause() instanceof GoogleJsonResponseException); | ||
| assumeFalse(403 == ((GoogleJsonResponseException) ex.getCause()).getStatusCode()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| try { | ||
| bytes = unauthorizedStorage.readAllBytes(landsatBucket, landsatBlob); | ||
| } catch (StorageException ex) { | ||
| assertTrue(ex.getCause() instanceof GoogleJsonResponseException); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
frankyn
approved these changes
Oct 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
-Tests relating to signing URLs are now properly skipped when a credential is provided that is incapable of signing
-Test accessing a public bucket is skipped if ran in an environment with restricted access