BigQuery: add missing query statistics. #3253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
reviewed
May 11, 2018
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
LGTM, but unsure on whether we need an enum for statement type.
| * CREATE_VIEW | ||
| * DROP_VIEW | ||
| */ | ||
| public String getStatementType() { return statementType; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pongad
reviewed
May 14, 2018
| private final TableId ddlTargetTable; | ||
| private final Long estimatedBytesProcessed; | ||
| private final Long numDmlAffectedRows; | ||
| private final List<TableId> referencedTables; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
approved these changes
May 16, 2018
pongad
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb through statistics in the API representation for query statistics:
Statement Type: SELECT, INSERT, CREATE_TABLE, etc
DDL Target Table and Operation Performed (how DDL statements manipulate their target)
DML: number of affected rows (e.g. rows affected by a UPDATE ... WHERE ...)
Referenced Tables: which tables were referenced by a query.
Total Partitions Processed
Total slot-milliseconds (query cost from a computation standpoint)