Skip to content

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented May 7, 2018

No description provided.

@pongad pongad requested a review from garrettjonesgoogle May 7, 2018 18:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2018
.setTotalTimeout(Duration.ofMillis(600000L))
.build();
definitions.put("default", settings);
settings =

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

[LICENSE]: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/LICENSE
[TESTING]: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/TESTING.md#testing-code-that-uses-redis

<!-- TODO: Update links when doc becomes available. -->

This comment was marked as spam.

This comment was marked as spam.

"projects/{project}/locations/{location}/instances/{instance}");

/** Formats a string containing the fully-qualified path to represent a location resource. */
public static final String formatLocationName(String project, String location) {

This comment was marked as spam.

This comment was marked as spam.

* @param instance Required. A Redis [Instance] resource
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Instance, Any> createInstanceAsync(

This comment was marked as spam.

This comment was marked as spam.

and move things to src/ directory. I'm not sure why this was missing
before.
@pongad pongad changed the title redis: add client Bach client regen and add Redis client May 7, 2018
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 188e477 into googleapis:master May 7, 2018
@pongad pongad deleted the redis branch May 7, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants