Skip to content

properly add equals() and compare fields #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 2 commits into from
May 1, 2018
Merged

properly add equals() and compare fields #3218

pongad merged 2 commits into from
May 1, 2018

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented May 1, 2018

No description provided.

@pongad pongad requested a review from garrettjonesgoogle May 1, 2018 19:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2018
garrettjonesgoogle
garrettjonesgoogle reviewed May 1, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests?

@pongad
Copy link
Contributor Author

pongad commented May 1, 2018

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit cfb0d01 into googleapis:master May 1, 2018
@pongad pongad deleted the add-equals branch May 1, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad @garrettjonesgoogle @googlebot