Skip to content

core: add hashCode to NoCredentials #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 1 commit into from
May 1, 2018
Merged

core: add hashCode to NoCredentials #3216

pongad merged 1 commit into from
May 1, 2018

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented May 1, 2018 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2018
@pongad pongad changed the title core: don't uselessly override equals core: add hashCode to NoCredentials May 1, 2018
neozwu
neozwu approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@neozwu neozwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 52b727a into googleapis:master May 1, 2018
@pongad pongad deleted the no-equals-over branch May 1, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

1 more reviewer

@neozwu neozwu neozwu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad @neozwu @googlebot