-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cleanup before protoc/grpc artifacts push #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <name>Google Cloud Natural Language</name> | ||
| <url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-language</url> | ||
| <url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-language | ||
| </url> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <version>0.45.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-notification:current} --> | ||
| <packaging>jar</packaging> | ||
| <name>Google Cloud Pub/Sub Notifications for Google Cloud Storage</name> | ||
| <name>Google Cloud Pub/Sub Notifications for GCS</name> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1,41 +0,0 @@ | |||
| Google Cloud Java Compatibility Checker | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| google-api-pom:0.11.0:0.11.0 | ||
| # children | ||
| #grpc-google-cloud-datastore-v1 | ||
| grpc-google-cloud-bigquerydatatransfer-v1:0.11.0:0.11.0 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
versions.txt
Outdated
| # | ||
| # common versions | ||
| # | ||
| #grpc-google-common-protos:1.9.0:1.9.0 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
garrettjonesgoogle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(this is to separate cleanup changes from the actual proto/grpc artifacts push, which is huge)
pom.xmls (remove unused/duplicate, partially wrong configuration)versions.txtto includeproto/grpcartifacts version (will be pushed immediately after this change is pushed). Also updatebump_versions.pyandreplace_versions.pyto strip whitespaces and support empty lines.Apache 2.0license (instead of Google Software License, which contains apache license in it (did compare the text, it is identical). Otherwise all third-party tools do not recognize the license (including github, looks like).