Skip to content

Conversation

@vam-google
Copy link
Contributor

@vam-google vam-google commented Apr 27, 2018

(this is to separate cleanup changes from the actual proto/grpc artifacts push, which is huge)

  1. Cleanup pom.xmls (remove unused/duplicate, partially wrong configuration)
  2. Update versions.txt to include proto/grpc artifacts version (will be pushed immediately after this change is pushed). Also update bump_versions.py and replace_versions.py to strip whitespaces and support empty lines.
  3. Fix License to pint explicitly to Apache 2.0 license (instead of Google Software License, which contains apache license in it (did compare the text, it is identical). Otherwise all third-party tools do not recognize the license (including github, looks like).
  4. Add Andrea and Hanzhen to developers list.

@vam-google vam-google requested a review from pongad as a code owner April 27, 2018 17:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2018
<name>Google Cloud Natural Language</name>
<url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-language</url>
<url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-language
</url>

This comment was marked as spam.

This comment was marked as spam.

<version>0.45.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-notification:current} -->
<packaging>jar</packaging>
<name>Google Cloud Pub/Sub Notifications for Google Cloud Storage</name>
<name>Google Cloud Pub/Sub Notifications for GCS</name>

This comment was marked as spam.

This comment was marked as spam.

@@ -1,41 +0,0 @@
Google Cloud Java Compatibility Checker

This comment was marked as spam.

google-api-pom:0.11.0:0.11.0
# children
#grpc-google-cloud-datastore-v1
grpc-google-cloud-bigquerydatatransfer-v1:0.11.0:0.11.0

This comment was marked as spam.

This comment was marked as spam.

versions.txt Outdated
#
# common versions
#
#grpc-google-common-protos:1.9.0:1.9.0

This comment was marked as spam.

This comment was marked as spam.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit b559d67 into googleapis:master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants