Skip to content

Allowing non-POJO Firestore classes to be subclassed for mocking #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 1 commit into from
Apr 26, 2018
Merged

Allowing non-POJO Firestore classes to be subclassed for mocking #3176

pongad merged 1 commit into from
Apr 26, 2018

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 20, 2018

Per customer request, this PR removes "final" from the classes that make up the API logic to allow for easier mocking.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2018
@pongad pongad merged commit 412cf0d into master Apr 26, 2018
@pongad pongad deleted the mrschmidt-removefinal branch April 26, 2018 18:32
@schmidt-sebastian schmidt-sebastian mentioned this pull request Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian @pongad @googlebot