Skip to content

Conversation

@schmidt-sebastian
Copy link
Contributor

This pulls in the Watch conformance tests from GoogleCloudPlatform/google-cloud-common#252

This PR also changes the Watch Target ID to 0x1 to make the tests pass (since the ID is arbitrary).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2018
@schmidt-sebastian schmidt-sebastian requested a review from jba April 19, 2018 13:32
@schmidt-sebastian schmidt-sebastian requested review from jba and removed request for jba April 19, 2018 13:32
Copy link

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schmidt-sebastian schmidt-sebastian assigned pongad and unassigned jba Apr 19, 2018
@pongad pongad merged commit d94eb19 into master Apr 19, 2018
@pongad pongad deleted the mrschmidt-watchtests branch April 19, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants