Skip to content

Conversation

@mikekap
Copy link

@mikekap mikekap commented Apr 16, 2018

This can be very useful for running transitive type checks.

@mikekap mikekap requested a review from pongad as a code owner April 16, 2018 04:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/**
* Returns the schema for the query result. Present only for successful dry run of
* non-legacy SQL queries.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again) but @tswast should sign off

@pongad pongad merged commit 167ef27 into googleapis:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants