Add support for new api features in BigQuery TimePartitioning. #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two features are requirePartitionFilter & field. Also this moves to using a builder instead of using more `of` methods since the number of combinations is large.
googlebot
added
the
cla: yes
pongad
reviewed
Apr 16, 2018
| /** | ||
| * A builder for {@code TimePartitioning} objects. | ||
| */ | ||
| public abstract static class Builder { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * If not set, the table is partitioned by pseudo column '_PARTITIONTIME'; if set, the table is | ||
| * partitioned by this field. | ||
| */ | ||
| public String getField() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Thank you for the PR! LGTM but @tswast should sign off. |
tswast
approved these changes
Apr 16, 2018
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Wonderful. Thanks a bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two features are requirePartitionFilter & field.
Also this moves to using a builder instead of using more
ofmethods since the number of combinations is large.