Skip to content

fix javadoc literal #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neozwu merged 1 commit into from
Apr 13, 2018
Merged

fix javadoc literal #3154

neozwu merged 1 commit into from
Apr 13, 2018

Conversation

@neozwu
Copy link
Contributor

@neozwu neozwu commented Apr 13, 2018

fix a javadoc issue that blocks release.

@neozwu neozwu requested review from andreamlin and vkedia April 13, 2018 23:13
@neozwu neozwu requested a review from pongad as a code owner April 13, 2018 23:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2018
garrettjonesgoogle
garrettjonesgoogle approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 13, 2018

We have encountered this one time too many - filed an issue to stop having our releases blocked by silly javadoc mistakes: #3155

@neozwu neozwu merged commit 25f6594 into googleapis:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreamlin andreamlin Awaiting requested review from andreamlin

@vkedia vkedia Awaiting requested review from vkedia

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neozwu @garrettjonesgoogle @googlebot