pubsub: stop Subscriber asynchronously #3144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is hard to do this completely async, but we can use a background thread so it doesn't block user code. Fixes #3134.
googlebot
added
the
cla: yes
|
LGTM but I'm still getting ramped on reviewing this repo and may not be your best reviewer. :P |
jeanbza
approved these changes
Apr 13, 2018
mdietz94
suggested changes
Apr 13, 2018
| requestObserver.onError(Status.CANCELLED.asException()); | ||
| // Don't onError; it appears erroring can cause gRPC to drop messages. | ||
| requestObserver.onCompleted(); | ||
| } finally { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@mdietz94 PTAL |
mdietz94
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hard to do this completely async, but we can use a background
thread so it doesn't block user code.
Fixes #3134.
Fixes #3065.
cc @mdietz94