internal: improve pubsub javadoc #3132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pongad
reviewed
Apr 6, 2018
Contributor
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
Did you forget to add files to the commit? This PR doesn't compile as is.
| } | ||
| }, | ||
| executor); | ||
| Executors.newCachedThreadPool()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Specifically show creation of executor, rather than leaving it up to the reader to figure out how to create an executor.
jeanbza
force-pushed
the
javadoc_call_out_executor
branch
from
7b0c755 to
b197126
Compare
Author
|
@pongad Whoops, didn't try compiling (doh). Fixed the issue. PTAL |
pongad
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing some friction I had, as someone who hadn't used executors before. I think it's good for this code to be as copy-paste-able as possible.
Also, being new to executors, let me know if there's a better executor to be the default recommendation.